linux-kernel - Re: [PATCH 1/2] fixup: "powerpc/perf: Add support for the hv 24x7 interface"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140407112236.3d65d99b@kryten>
Date:	Mon, 7 Apr 2014 11:22:36 +1000
From:	Anton Blanchard <anton@...ba.org>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Cody P Schafer <cody@...ux.vnet.ibm.com>,
	Michael Ellerman <michael@...erman.id.au>,
	Linux PPC <linuxppc-dev@...ts.ozlabs.org>,
	cody+local@...ux.vnet.ibm.com, LKML <linux-kernel@...r.kernel.org>,
	David.Laight@...lab.com
Subject: Re: [PATCH 1/2] fixup: "powerpc/perf: Add support for the hv 24x7
 interface"

Hi

> That's not much less awful... The message gives 0 informations about
> where it comes from .. what is it that couldn't obtain capabilities ?

Cody is at least using pr_fmt to give some information on what went
wrong:

[    1.635040] hv-24x7: not a virtualized system, not enabling
[    1.635079] hv-gpci: not a virtualized system, not enabling

I think this is way too chatty though. If every driver printed a couple
of lines we'd end up with thousands of useless lines in the dmesg.

I still would prefer to see these as pr_debug lines.

Anton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/