linux-kernel - Re: [PATCH] staging: rtl8187se: Fix warning symbol should be static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140406160903.GA8114@leaf>
Date:	Sun, 6 Apr 2014 09:09:03 -0700
From:	Josh Triplett <josh@...htriplett.org>
To:	Jonas Hahnfeld <hahnjo@...njo.de>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ana Rey <anarey@...il.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Pablo Neira Ayuso <pablo@...monks.org>,
	Rashika Kheria <rashika.kheria@...il.com>,
	Andreea-Cristina Bernat <bernat.ada@...il.com>,
	Andrea Merello <andrea.merello@...il.com>,
	Teodora Baluta <teobaluta@...il.com>,
	Dan LaManna <dan.lamanna@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8187se: Fix warning symbol should be static

On Sun, Apr 06, 2014 at 05:46:04PM +0200, Jonas Hahnfeld wrote:
> This patch solves some sparse warnings about "symbol [...] was not
> declared. Should it be static?" by including the correct header files.
> 
> Signed-off-by: Jonas Hahnfeld <hahnjo@...njo.de>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

> Tested by compile only
> 
>  drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c      | 1 +
>  drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c | 1 +
>  drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c  | 1 +
>  drivers/staging/rtl8187se/r8180_wx.c                       | 1 +
>  4 files changed, 4 insertions(+)
> 
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c
> index 101f0c0..03462c3 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c
> @@ -19,6 +19,7 @@
>  #include <linux/string.h>
>  #include <linux/errno.h>
>  
> +#include "../r8180.h"
>  #include "ieee80211.h"
>  
>  MODULE_AUTHOR("Jouni Malinen");
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c
> index 4fe2538..7eae3d9 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c
> @@ -21,6 +21,7 @@
>  #include <linux/string.h>
>  #include <linux/wireless.h>
>  
> +#include "../r8180.h"
>  #include "ieee80211.h"
>  
>  #include <linux/crypto.h>
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c
> index f253672..288f86c 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c
> @@ -17,6 +17,7 @@
>  #include <linux/skbuff.h>
>  #include <linux/string.h>
>  
> +#include "../r8180.h"
>  #include "ieee80211.h"
>  
>  #include <linux/crypto.h>
> diff --git a/drivers/staging/rtl8187se/r8180_wx.c b/drivers/staging/rtl8187se/r8180_wx.c
> index b552491..57bf01f 100644
> --- a/drivers/staging/rtl8187se/r8180_wx.c
> +++ b/drivers/staging/rtl8187se/r8180_wx.c
> @@ -20,6 +20,7 @@
>  
>  #include "r8180.h"
>  #include "r8180_hw.h"
> +#include "r8180_wx.h"
>  
>  #include <net/iw_handler.h>
>  #include "ieee80211/dot11d.h"
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/