linux-kernel - Re: linux-next: Tree for Apr 1 (netfilter)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 6 Apr 2014 18:08:47 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	David Miller <davem@...emloft.net>
Cc:	Randy Dunlap <rdunlap@...radead.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Linux-Next <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	netfilter-devel@...r.kernel.org,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: linux-next: Tree for Apr 1 (netfilter)

Hi David,

On Sun, Apr 6, 2014 at 5:31 PM, David Miller <davem@...emloft.net> wrote:
>> On Tue, Apr 1, 2014 at 9:22 PM, David Miller <davem@...emloft.net> wrote:
>>> From: Randy Dunlap <rdunlap@...radead.org>
>>> Date: Tue, 01 Apr 2014 11:34:15 -0700
>>>> on x86_64:
>>>>
>>>> net/netfilter/xt_connlimit.c: In function 'connlimit_mt_check':
>>>> net/netfilter/xt_connlimit.c:380:18: warning: division by zero [-Wdiv-by-zero]
>>>>
>>>> Maybe just use CONNLIMIT_LOCK_SLOTS instead of ARRAY_SIZE(...).
>>>
>>> I'd rather see that ARRAY_SIZE() be adjusted to work cleanly for zero
>>> sized array elements.
>>
>> Anyone with a suggestion?
>>
>> Please note this is now in Linus' tree, possibly crashing people's boxes...
>
> I took in the version of the fix I didn't like via Pablo for
> now.

Thank you!

Fixing ARRAY_SIZE() can still be done later, if possible.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvald
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/