lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Apr 2014 12:11:15 -0500 From: Josh Cartwright <joshc@...eaurora.org> To: Tien Hock Loh <thloh@...era.com> Cc: robh+dt@...nel.org, pawel.moll@....com, Mark Rutland <mark.rutland@....com>, ijc+devicetree@...lion.org.uk, Kumar Gala <galak@...eaurora.org>, Rob Landley <rob@...dley.net>, Linus Walleij <linus.walleij@...aro.org>, Alexandre Courbot <gnurou@...il.com>, Grant Likely <grant.likely@...aro.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, dinguyen@...era.com, "lftan@...era.com" <lftan@...era.com> Subject: Re: [PATCH V7 1/1] drivers/gpio: Altera soft IP GPIO driver and devicetree binding On Mon, Apr 07, 2014 at 04:00:43PM +0800, Tien Hock Loh wrote: > On Wed, Mar 19, 2014 at 6:09 PM, Tien Hock Loh <thloh@...era.com> wrote: > > On Fri, Mar 7, 2014 at 11:14 PM, Josh Cartwright <joshc@...eaurora.org> wrote: > >> On Mon, Mar 03, 2014 at 06:27:43PM +0800, thloh@...era.com wrote: > >>> From: Tien Hock Loh <thloh@...era.com> [..] > >>> + altera_gc->mapped_irq = irq_of_parse_and_map(node, 0); > >>> > >> > >> platform_get_irq(pdev, 0); > >> > > OK. > > > > platform_get_irq doesn't create the irq mapping which is needed by the > driver. Since this driver is targeted at using of, should I be using > irq_of_parse_and_map or should I still redo the codes with > platform_get_irq and irq_create_mapping? I think the latter would be > introducing code redundancy. Please advice. Yes, it is technically true that platform_get_irq() doesn't do the mapping directly, but that's because the mapping is setup earlier, when of_device_alloc() (drivers/of/platform.c) allocates resources for your platform device. Calling irq_of_parse_and_map() should be unnecessary. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists