linux-kernel - Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1396959284.28420.45.camel@iivanov-dev>
Date:	Tue, 08 Apr 2014 15:14:44 +0300
From:	"Ivan T. Ivanov" <iivanov@...sol.com>
To:	Timur Tabi <timur@...eaurora.org>
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	devicetree@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node


Hi,

On Mon, 2014-04-07 at 18:53 -0500, Timur Tabi wrote:
> On Thu, Feb 6, 2014 at 9:28 AM, Ivan T. Ivanov <iivanov@...sol.com> wrote:
> > +                       spi8_default: spi8_default {
> > +                               mosi {
> > +                                       pins = "gpio45";
> > +                                       function = "blsp_spi8";
> > +                               };
> > +                               miso {
> > +                                       pins = "gpio46";
> > +                                       function = "blsp_spi8";
> > +                               };
> > +                               cs {
> > +                                       pins = "gpio47";
> > +                                       function = "blsp_spi8";
> > +                               };
> > +                               clk {
> > +                                       pins = "gpio48";
> > +                                       function = "blsp_spi8";
> > +                               };
> 
> I'm confused by this.  Isn't this information already defined in the
> pinctrl-msm8x74.c driver?
> 
> static const char * const blsp_spi8_groups[] = {
>     "gpio45", "gpio46", "gpio47", "gpio48"
> };

I am not sure that I understand the question. This is one of 
possible ways to describe relationship between pins and functions. 
As they are described is visible what is their real purpose.

Regards,
Ivan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/