linux-kernel - Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5343EC87.700@codeaurora.org>
Date:	Tue, 08 Apr 2014 07:33:11 -0500
From:	Timur Tabi <timur@...eaurora.org>
To:	"Ivan T. Ivanov" <iivanov@...sol.com>
CC:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	devicetree@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

Ivan T. Ivanov wrote:
>> >I'm confused by this.  Isn't this information already defined in the
>> >pinctrl-msm8x74.c driver?
>> >
>> >static const char * const blsp_spi8_groups[] = {
>> >     "gpio45", "gpio46", "gpio47", "gpio48"
>> >};
> I am not sure that I understand the question. This is one of
> possible ways to describe relationship between pins and functions.
> As they are described is visible what is their real purpose.

Ok, let me rephrase.

The 8x74 pinctrl driver already contains this information.  It already 
defines a "blsp_spi8" group consisting of GPIOs 45, 46, 47, and 48.

This patch adds that same exact information into the device tree.  Why 
are we duplicating that information?  Why add it to the device tree when 
it's already in the driver (and already working).

Also, I don't see any code anywhere that uses these new device tree nodes.

--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/