linux-kernel - Re: [PATCH v10 1/1] Tracepoint: register/unregister struct tracepoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140408154401.03adc51d@gandalf.local.home>
Date:	Tue, 8 Apr 2014 15:44:01 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Frank Ch. Eigler" <fche@...hat.com>,
	Johannes Berg <johannes.berg@...el.com>
Subject: Re: [PATCH v10 1/1] Tracepoint: register/unregister struct
 tracepoint

On Tue, 8 Apr 2014 19:35:54 +0000 (UTC)
Mathieu Desnoyers <mathieu.desnoyers@...icios.com> wrote:

> > 
> > > +{
> > > +	if (call->flags & TRACE_EVENT_FL_TRACEPOINT)
> > > +		return call->tp ? call->tp->name : NULL;
> > > +	else
> > > +		return call->name;
> > > +}
> > 
> > Also, you missed a bunch of conversions in trace_event.c file. Do a
> > search for '->name' and you'll find them. The ones that shouldn't be
> > converted are rather obvious (system, field, mod), but you'll see
> > others that were missed. I'm a bit nervous about what other ones may be
> > missed as well.
> 
> Got them. I noticed that I forgot to turn on CONFIG_DYNAMIC_FTRACE when
> I did the original swap from name to _name to find the sites to update.
> 
> I did test more recently with a config that has all the FTRACE and PERF
> features enabled, but that was after I swapped back from _name to name,
> so I did not catch those two sites.
> 
> I just swapped the field name to _name again, and did the build with
> all FTRACE and PERF config options enabled to be certain I did not miss
> any. Just to be extra sure, I'm doing a make allyesconfig too.
> 
> Then, I'm changing _name back to name, and I'll prepare this as v11.
> 
> Is that OK with you ?
> 

Maybe you want to build with an allmodconfig to make sure. You probably
did get everything, but just to be sure.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/