linux-kernel - Re: [PATCH V2] tty: fix memleak in alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140414120706.45ce288c@alan.etchedpixels.co.uk>
Date:	Mon, 14 Apr 2014 12:07:06 +0100
From:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:	Chen Tingjie <tingjie.chen@...el.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>, linux-kernel@...r.kernel.org,
	Zhang Jun <jun.zhang@...el.com>
Subject: Re: [PATCH V2] tty: fix memleak in alloc_pid

> move spin_unlock(sighand->siglock) after get_current_tty() can avoid
> the race and fix the memleak.

We already take tty_ctrl_lock inside sighand->siglock so this all appears
safe and correct to me.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/