linux-kernel - Re: [PATCH 1/1] kernel/rcu/tree.c: remove duplicate extern definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140414160743.GF4496@linux.vnet.ibm.com>
Date:	Mon, 14 Apr 2014 09:07:43 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Pranith Kumar <pranith@...ech.edu>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] kernel/rcu/tree.c: remove duplicate extern definition

On Sun, Apr 13, 2014 at 05:53:53PM -0400, Pranith Kumar wrote:
> remove duplicate definition of extern resched_cpu
> 
> Signed-off-by: Pranith Kumar <bobby.prani@...il.com>

Hello, Pranith,

When I apply this patch I get the following:

/home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c: In function ‘rcu_implicit_dynticks_qs’:
/home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c:895:3: error: implicit declaration of function ‘resched_cpu’ [-Werror=implicit-function-declaration]
/home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c: At top level:
/home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c:1009:13: warning: conflicting types for ‘resched_cpu’ [enabled by default]
/home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c:895:3: note: previous implicit declaration of ‘resched_cpu’ was here

This failed in under number of different Kconfig setups, the .config file
for one of them is attached.

So this declaration really is needed.  Just out of curiosity, what led
you to believe that it could be removed?

							Thanx, Paul

> ---
>  kernel/rcu/tree.c |    6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 0c47e30..67e850a 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -947,12 +947,6 @@ static void print_other_cpu_stall(struct rcu_state
> *rsp)
>      force_quiescent_state(rsp);  /* Kick them all. */
>  }
> 
> -/*
> - * This function really isn't for public consumption, but RCU is special in
> - * that context switches can allow the state machine to make progress.
> - */
> -extern void resched_cpu(int cpu);
> -
>  static void print_cpu_stall(struct rcu_state *rsp)
>  {
>      int cpu;
> -- 
> 1.7.9.5
> 
> 
> -- 
> Pranith

View attachment ".config" of type "text/plain" (93563 bytes)