linux-kernel - Re: [PATCH v2 1/2] regulator: pbias: Fix is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Apr 2014 22:16:44 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Chris Ball <chris@...ntf.net>, Liam Girdwood <lgirdwood@...il.com>,
	Balaji T K <balajitk@...com>,
	Florian Vaussard <florian.vaussard@...l.ch>,
	Stefan Roese <sr@...x.de>, linux-kernel@...r.kernel.org,
	linux-mmc@...r.kernel.org
Subject: Re: [PATCH v2 1/2] regulator: pbias: Fix is_enabled callback
 implementation

On Sat, Mar 08, 2014 at 11:55:29AM +0800, Axel Lin wrote:
> The is_enabled implementation is wrong in some cases:
> e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
> However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits.
> So is_enabled callback will always return false in this case.
> Fix the logic to compare the register value with info->enable rather than
> info->enable_mask.

Applied both, thanks.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)