linux-kernel - Re: [PATCH v2 1/2] regulator: pbias: Fix is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFRkauDTvEGoaWFBtPWHtw-JFmhTbdHcxoVP56fnv1YG047Knw@mail.gmail.com>
Date:	Tue, 15 Apr 2014 23:14:13 +0800
From:	Axel Lin <axel.lin@...ics.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	Chris Ball <chris@...ntf.net>, Liam Girdwood <lgirdwood@...il.com>,
	Balaji T K <balajitk@...com>,
	Florian Vaussard <florian.vaussard@...l.ch>,
	Stefan Roese <sr@...x.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-mmc@...r.kernel.org
Subject: Re: [PATCH v2 1/2] regulator: pbias: Fix is_enabled callback implementation

2014-04-15 5:16 GMT+08:00 Mark Brown <broonie@...nel.org>:
> On Sat, Mar 08, 2014 at 11:55:29AM +0800, Axel Lin wrote:
>> The is_enabled implementation is wrong in some cases:
>> e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
>> However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits.
>> So is_enabled callback will always return false in this case.
>> Fix the logic to compare the register value with info->enable rather than
>> info->enable_mask.
>
> Applied both, thanks.

Hi Mark,
Currently these 2 commits are in topic/pbias branch.

I think commit 1cb7b43f6796
"regulator: pbias: Fix is_enabled callback implementation"
is a bug fix for 3.15.

commit 60e8c1e34d3a
"regulator: pbias: Convert to use regmap helper functions"
might also required for 3.15.
The reason is this commit implements .list_voltage and the mmc core calls
regulator_list_voltage() in mmc_regulator_get_ocrmask().

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/