linux-kernel - RE: [PATCH] pwm_lpss: Add support for PCI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <604BF5F4C5D71041942BC7E84ED659EA01570E4F@PGSMSX103.gar.corp.intel.com>
Date:	Tue, 15 Apr 2014 08:59:31 +0000
From:	"Chew, Chiau Ee" <chiau.ee.chew@...el.com>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
CC:	"Li, Aubrey" <aubrey.li@...ux.intel.com>,
	Thierry Reding <thierry.reding@...il.com>,
	Alan Cox <alan@...ux.intel.com>,
	"linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] pwm_lpss: Add support for PCI devices

> On Mon, Apr 14, 2014 at 02:05:25AM +0000, Chew, Chiau Ee wrote:
> > > >  MODULE_DESCRIPTION("PWM driver for Intel LPSS");
> > > >MODULE_AUTHOR("Mika  Westerberg
> > > ><mika.westerberg@...ux.intel.com>");
> > > >  MODULE_LICENSE("GPL v2");
> > > >  MODULE_ALIAS("platform:pwm-lpss");
> > >
> > > Looks a good idea to combine pci and acpi driver together.
> > > Since pci driver is added, here the alias need to be refined.
> > > Others look good.
> > >
> > > Thanks,
> > > -Aubrey
> >
> > Ok. I will change it to MODULE_ALIAS("pci/platform:pwm-lpss");
> 
> Hmm, does that really work like that?
> 
> For PCI and ACPI you already have tables with MODULE_DEVICE_TABLE().
> 
> For pure platform driver (which is probably not going to be used) you nede to
> have MODULE_ALIAS() if you want modprobe to load it automagically.

Ok, looks like MODULE_ALIAS() is a redundant. I will remove it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/