linux-kernel - Re: [PATCH] x86, MCE: Clean get_cpu_xxx with this_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140415090347.GA31409@gmail.com>
Date:	Tue, 15 Apr 2014 11:03:48 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	"Chen, Gong" <gong.chen@...ux.intel.com>
Cc:	hpa@...or.com, tony.luck@...el.com, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org
Subject: Re: [PATCH] x86, MCE: Clean get_cpu_xxx with this_cpu_xxx


* Chen, Gong <gong.chen@...ux.intel.com> wrote:

> This is a cleanup patch suggested by Peter. Use new
> this_cpu_xxx to improve operation speed. Meanwhile,
> it fixes an issue introduced in commit 27f6c573e0. I
> forget to execute put_cpu_var operation after get_cpu_var.

What 'issue'? Is it a bug? If yes, what are the symptoms to the user?

Also, fixes must be separate from cleanups.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/