linux-kernel - Re: [PATCH] x86, MCE: Clean get_cpu_xxx with this_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140416013459.GA4399@gchen.bj.intel.com>
Date:	Tue, 15 Apr 2014 21:34:59 -0400
From:	"Chen, Gong" <gong.chen@...ux.intel.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	hpa@...or.com, tony.luck@...el.com, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org
Subject: Re: [PATCH] x86, MCE: Clean get_cpu_xxx with this_cpu_xxx

On Tue, Apr 15, 2014 at 11:03:48AM +0200, Ingo Molnar wrote:
> Date: Tue, 15 Apr 2014 11:03:48 +0200
> From: Ingo Molnar <mingo@...nel.org>
> To: "Chen, Gong" <gong.chen@...ux.intel.com>
> Cc: hpa@...or.com, tony.luck@...el.com, tglx@...utronix.de,
>  linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org
> Subject: Re: [PATCH] x86, MCE: Clean get_cpu_xxx with this_cpu_xxx
> User-Agent: Mutt/1.5.21 (2010-09-15)
> 
> 
> * Chen, Gong <gong.chen@...ux.intel.com> wrote:
> 
> > This is a cleanup patch suggested by Peter. Use new
> > this_cpu_xxx to improve operation speed. Meanwhile,
> > it fixes an issue introduced in commit 27f6c573e0. I
> > forget to execute put_cpu_var operation after get_cpu_var.
> 
> What 'issue'? Is it a bug? If yes, what are the symptoms to the user?
I forget put_cpu_var after get_cpu_var.

> 
> Also, fixes must be separate from cleanups.
OK, I will.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)