linux-kernel - Re: [PATCH v2 8/8] sh: clk: Use cpufreq_for_each_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140416041345.GC27534@verge.net.au>
Date:	Wed, 16 Apr 2014 13:13:46 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Stratos Karafotis <stratosk@...aphore.gr>
Cc:	Magnus Damm <magnus.damm@...il.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	linux-sh@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 8/8] sh: clk: Use cpufreq_for_each_valid_entry macro
 for iteration

On Wed, Apr 16, 2014 at 01:27:04AM +0300, Stratos Karafotis wrote:
> The cpufreq core now supports the cpufreq_for_each_valid_entry macro
> helper for iteration over the cpufreq_frequency_table, so use it.
> 
> It should have no functional changes.
> 
> Signed-off-by: Stratos Karafotis <stratosk@...aphore.gr>

Rafael, please feel free to take this one.

Acked-by: Simon Horman <horms+renesas@...ge.net.au>

> ---
>  drivers/sh/clk/core.c | 20 +++++---------------
>  1 file changed, 5 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/sh/clk/core.c b/drivers/sh/clk/core.c
> index 7472785..be56b22 100644
> --- a/drivers/sh/clk/core.c
> +++ b/drivers/sh/clk/core.c
> @@ -196,17 +196,11 @@ int clk_rate_table_find(struct clk *clk,
>  			struct cpufreq_frequency_table *freq_table,
>  			unsigned long rate)
>  {
> -	int i;
> -
> -	for (i = 0; freq_table[i].frequency != CPUFREQ_TABLE_END; i++) {
> -		unsigned long freq = freq_table[i].frequency;
> +	struct cpufreq_frequency_table *pos;
>  
> -		if (freq == CPUFREQ_ENTRY_INVALID)
> -			continue;
> -
> -		if (freq == rate)
> -			return i;
> -	}
> +	cpufreq_for_each_valid_entry(pos, freq_table)
> +		if (pos->frequency == rate)
> +			return pos - freq_table;
>  
>  	return -ENOENT;
>  }
> @@ -575,11 +569,7 @@ long clk_round_parent(struct clk *clk, unsigned long target,
>  		return abs(target - *best_freq);
>  	}
>  
> -	for (freq = parent->freq_table; freq->frequency != CPUFREQ_TABLE_END;
> -	     freq++) {
> -		if (freq->frequency == CPUFREQ_ENTRY_INVALID)
> -			continue;
> -
> +	cpufreq_for_each_valid_entry(freq, parent->freq_table) {
>  		if (unlikely(freq->frequency / target <= div_min - 1)) {
>  			unsigned long freq_max;
>  
> -- 
> 1.9.0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/