linux-kernel - Re: [PATCH v5 0/9] mfd: max14577: Add support for MAX77836

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140416102846.GL4754@lee--X1>
Date:	Wed, 16 Apr 2014 11:28:46 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH v5 0/9] mfd: max14577: Add support for MAX77836

> This is first part of fifth version of patchset adding support for
> MAX77836 device to the max14577 driver.
> 
> I decided to split the patchset into smaller parts. I hope this would
> help in getting necessary review/acks from maintainers.
> 
> The first part introduces changes in max14577 driver and adds support
> for MAX77836 in MFD, extcon and regulator drivers. Most of these
> patches already have required acks from maintainers.
> Full v4 patchset can be found here:
> http://thread.gmane.org/gmane.linux.kernel/1654267

So what's the plan for this driver now? What's missing? Do you have
all the Acks you need? If so, I'm happy to apply this patch-set and
supply a pull-request to the other maintainers.

> Changes since v4
> ================
> 1. Updated Kconfig entries mentioning MAX77836.
> 2. Removed rename-like patches:
>    [PATCH v4 02/16] mfd: max14577: Rename and add MAX14577 symbols
>    [PATCH v4 03/16] mfd: max14577: Rename state container to maxim_core
> 3. Added new patches (not yet reviewed):
>    [PATCH v5 2/9] mfd: max14577: Add muic prefix to regmap config
>    [PATCH v5 6/9] mfd: max14577: Add MAX14577 prefix to IRQ defines
> 4. Rebased on 3.15-rc1.
> 
> Changes since v3
> ================
> 1. Applied minor fixes (pointed by Lee Jones).
> 2. Added one ACK (Lee Jones) and Review-by (Tomasz Figa).
> 3. Patch 14/charger: Minor change in parsing EOC value from DTS.
> 4. Rebased on next-20140224.
> 
> Changes since v2
> ================
> 1. Added ACK-s.
> 2. Applied minor checkpatch fixes (pointed by Lee Jones).
> 3. Rebased on next-20140217.
> 
> Changes since v1
> ================
> 1. Added ACK-s, reviews and tested-by tags.
> 2. Removed applied patches (they were merged to the linux-next tree).
> 3. Applied comments from review (Lee Jones) to 5/15 (detection of device type)
>    and 8/15 (add max77836 support to max14577).
> 4. Rebased on next tree.
> 5. Added patch 13 and 14 (pointed by Jenny Tc):
>    - regulator/mfd: max14577: Export symbols for calculating charger current
>    - charger: max14577: Configure battery-dependent settings from DTS
> 6. Updated bindings documentation with new charger bindings.
> Previous thread:
>  - [PATCH 00/18] mfd: max14577: Add support for MAX77836
>    http://thread.gmane.org/gmane.linux.kernel/1636654/focus=1636674
> 
> 
> Description
> ===========
> The MAX77836 is almost the same as MAX14577. Basically it is an extended
> version of MAX14577. The chipsets have same MUIC component so the extcon,
> charger and regulators require only little adjustments. More changes were
> needed in the charger (because it uses lower charging current) and regulator
> drivers (because mentioned different charing current and additional
> regulators). The MAX77836 has also PMIC and Fuel Gauge (which is the same
> as MAX17040/17048 Fuel Gauge).
> 
> The MAX77836 uses three I2C slave addresses and has additional interrupts
> (related to PMIC and Fuel Gauge). It has also Interrupt Source register,
> just like MAX77686 and MAX77693.
> 
> 
> Best regards,
> Krzysztof Kozlowski
> 
> 
> Chanwoo Choi (1):
>   extcon: max14577: Change extcon name instead of static name according
>     to device type
> 
> Krzysztof Kozlowski (8):
>   mfd: max14577: Add muic prefix to regmap config
>   mfd: max14577: Add detection of device type
>   extcon: max14577: Add max14577 prefix to muic_irqs
>   extcon: max14577: Choose muic_irqs according to device type
>   mfd: max14577: Add MAX14577 prefix to IRQ defines
>   mfd: max77836: Add MAX77836 support to max14577 driver
>   extcon: max14577: Add support for MAX77836
>   regulator: max14577: Add support for MAX77836 regulators
> 
>  drivers/extcon/Kconfig               |   4 +-
>  drivers/extcon/extcon-max14577.c     | 174 +++++++++++++------
>  drivers/mfd/Kconfig                  |   6 +-
>  drivers/mfd/max14577.c               | 315 ++++++++++++++++++++++++++++++-----
>  drivers/regulator/Kconfig            |   7 +-
>  drivers/regulator/max14577.c         | 277 ++++++++++++++++++++++++++----
>  include/linux/mfd/max14577-private.h | 222 ++++++++++++++++++------
>  include/linux/mfd/max14577.h         |  19 ++-
>  8 files changed, 836 insertions(+), 188 deletions(-)
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/