linux-kernel - Re: [PATCH 2/2] workqueue: jumps to use_dfl_pwq if the target cpumask is equal wq's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140416173837.GO1257@htj.dyndns.org>
Date:	Wed, 16 Apr 2014 13:38:37 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Daeseok Youn <daeseok.youn@...il.com>
Cc:	laijs@...fujitsu.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] workqueue: jumps to use_dfl_pwq if the target
 cpumask is equal wq's

Hello,

On Wed, Apr 16, 2014 at 02:33:27PM +0900, Daeseok Youn wrote:
> 
> Replace blocks of code which checks whether pwq is defalut with
> jump to use_dfl_pwq. It is same as before.

A better wording would be sth like

 wq_update_unbound_numa(), when it's decided that the newly updated
 cpumask equals the default, looks at whether the current pwq is
 already the default one and skips setting pwq to the default one.
 This extra step is unnecessary and we can always jump to use_dfl_pwq
 instead.  Simplify the code by removing the conditional.  This
 doesn't make any functional difference.

> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
> ---
>  kernel/workqueue.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 3150b21..0679854 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -4087,10 +4087,7 @@ static void wq_update_unbound_numa(struct workqueue_struct *wq, int cpu,
>  		if (cpumask_equal(cpumask, pwq->pool->attrs->cpumask))
>  			goto out_unlock;
>  	} else {
> -		if (pwq == wq->dfl_pwq)
> -			goto out_unlock;
> -		else
> -			goto use_dfl_pwq;
> +		goto use_dfl_pwq;

As I said before, please update the comment above to match the new
code.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/