[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20140416232331.GF4496@linux.vnet.ibm.com>
Date: Wed, 16 Apr 2014 16:23:31 -0700
From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To: Pranith Kumar <pranith@...ech.edu>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] kernel/rcu/rcutorture.c: use macro to define module
parameter
On Wed, Apr 16, 2014 at 07:10:41PM -0400, Pranith Kumar wrote:
> On Wed, Apr 16, 2014 at 5:14 PM, Paul E. McKenney
> <paulmck@...ux.vnet.ibm.com> wrote:
> >
> > This fails for me. The problem is that the defined macro makes everything
> > static, and rcutorture_runnable is used in kernel/sysctl.c. :-/
> >
> > In theory, it would be possible to make torture_param() take "static"
> > as a parameter, but this adds more characters than it removes.
> >
>
> Oh, I just tried building it as a module and it worked. In the future
> I will run this both as inbuilt and as a module before sending any
> patches.
>
> Sorry for the noise!
This is not noise! I do intend to use it as a module in the future, so
it is helpful that you found and fixed the other bugs. I really cannot
complain about one bad patch out of several useful fixes! So please
do keep trying things and looking at things in RCU. ;-)
Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists