linux-kernel - Re: [PATCH v2 5/5] regulator: tps65090: Make FETs more reliable by adding retries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPnjgZ13C78CoWHnpB5j=FBBQgYfe7+Si+JiUbuaV+ty3u-Oww@mail.gmail.com>
Date:	Wed, 16 Apr 2014 17:24:55 -0600
From:	Simon Glass <sjg@...omium.org>
To:	Doug Anderson <dianders@...omium.org>
Cc:	Anton Vorontsov <anton@...msg.org>,
	Olof Johansson <olof@...om.net>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	AJAY KUMAR RAMAKRISHNA SHYMALAMMA <ajaykumar.rs@...sung.com>,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	Michael Spang <spang@...omium.org>,
	Sean Paul <seanpaul@...omium.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	lk <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 5/5] regulator: tps65090: Make FETs more reliable by
 adding retries

Hi Doug,

On 16 April 2014 15:25, Doug Anderson <dianders@...omium.org> wrote:
> Simon,
>
> On Wed, Apr 16, 2014 at 1:50 PM, Simon Glass <sjg@...omium.org> wrote:
>>> +#define MAX_CTRL_READ_TRIES    5
>>> +#define MAX_FET_ENABLE_TRIES   1000
>>
>> Gosh that is a lot of tries - should we maybe give up sooner?
>
> That's actually a squash of a recent patch.  See
> <https://chromium-review.googlesource.com/189239>.  I've specifically
> seen at least one case on my device where it needed 888 retries at
> bootup!
>
> ...on my really old Chromebook, it seems to get into a bad state if it
> sits on my desk for a long time.  After I use it a bit it rarely needs
> more than 10 retries.

Try to be kinder to your hardware?

Anyway, fair enough, if you've seen 888 then we need to deal with that case.

Regards,
Simon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/