linux-kernel - [tip:irq/urgent] clocksource: Exynos_mct: Register clock event after request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-8db6e5104b77de5d0b7002b95069da0992a34be9@git.kernel.org>
Date:	Thu, 17 Apr 2014 14:40:24 -0700
From:	tip-bot for Krzysztof Kozlowski <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...nel.org,
	k.kozlowski@...sung.com, kgene.kim@...sung.com,
	kyungmin.park@...sung.com, b.zolnierkie@...sung.com,
	m.szyprowski@...sung.com, tglx@...utronix.de
Subject: [tip:irq/urgent] clocksource: Exynos_mct:
  Register clock event after request_irq()

Commit-ID:  8db6e5104b77de5d0b7002b95069da0992a34be9
Gitweb:     http://git.kernel.org/tip/8db6e5104b77de5d0b7002b95069da0992a34be9
Author:     Krzysztof Kozlowski <k.kozlowski@...sung.com>
AuthorDate: Wed, 16 Apr 2014 14:36:45 +0000
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Thu, 17 Apr 2014 23:36:28 +0200

clocksource: Exynos_mct: Register clock event after request_irq()

After hotplugging CPU1 the first call of interrupt handler for CPU1
oneshot timer was called on CPU0 because it fired before setting IRQ
affinity. Affected are SoCs where Multi Core Timer interrupts are
shared (SPI), e.g. Exynos 4210.

During setup of the MCT timers the clock event device should be
registered after setting the affinity for interrupt. This will prevent
starting the timer too early.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Cc: Kyungmin Park <kyungmin.park@...sung.com>
Cc: Marek Szyprowski <m.szyprowski@...sung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc: Tomasz Figa <t.figa@...sung.com>,
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>,
Cc: Kukjin Kim <kgene.kim@...sung.com>
Cc: linux-arm-kernel@...ts.infradead.org,
Cc: stable@...r.kernel.org
Link: http://lkml.kernel.org/r/20140416143316.299247848@linutronix.de
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
 drivers/clocksource/exynos_mct.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c
index b2d4163..acf5a32 100644
--- a/drivers/clocksource/exynos_mct.c
+++ b/drivers/clocksource/exynos_mct.c
@@ -416,8 +416,6 @@ static int exynos4_local_timer_setup(struct clock_event_device *evt)
 	evt->set_mode = exynos4_tick_set_mode;
 	evt->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT;
 	evt->rating = 450;
-	clockevents_config_and_register(evt, clk_rate / (TICK_BASE_CNT + 1),
-					0xf, 0x7fffffff);
 
 	exynos4_mct_write(TICK_BASE_CNT, mevt->base + MCT_L_TCNTB_OFFSET);
 
@@ -434,6 +432,8 @@ static int exynos4_local_timer_setup(struct clock_event_device *evt)
 	} else {
 		enable_percpu_irq(mct_irqs[MCT_L0_IRQ], 0);
 	}
+	clockevents_config_and_register(evt, clk_rate / (TICK_BASE_CNT + 1),
+					0xf, 0x7fffffff);
 
 	return 0;
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/