| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1397782610-7370-1-git-send-email-joelf@ti.com> Date: Thu, 17 Apr 2014 19:56:50 -0500 From: Joel Fernandes <joelf@...com> To: <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>, <davinci-linux-open-source@...ux.davincidsp.com> CC: Joel Fernandes <joelf@...com>, Vinod Koul <vinod.koul@...el.com>, Dan Williams <dan.j.williams@...el.com>, Russell King <rmk+kernel@....linux.org.uk> Subject: [PATCH] [FIX] dmaengine: virt-dma: Free descriptor after callback Free the vd (virt descriptor) after the callback is called. In EDMA driver atleast which uses virt-dma, we make use of the desc during the callback and if its dangerously freed before the callback is called. I also noticed this in omap-dma dmaengine driver. Cc: Vinod Koul <vinod.koul@...el.com> Cc: Dan Williams <dan.j.williams@...el.com> Cc: Russell King <rmk+kernel@....linux.org.uk> Signed-off-by: Joel Fernandes <joelf@...com> --- drivers/dma/virt-dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma/virt-dma.c b/drivers/dma/virt-dma.c index 6f80432..98aeb7f 100644 --- a/drivers/dma/virt-dma.c +++ b/drivers/dma/virt-dma.c @@ -84,10 +84,10 @@ static void vchan_complete(unsigned long arg) list_del(&vd->node); - vc->desc_free(vd); - if (cb) cb(cb_data); + + vc->desc_free(vd); } } -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists