| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140418085019.GN27282@n2100.arm.linux.org.uk> Date: Fri, 18 Apr 2014 09:50:19 +0100 From: Russell King - ARM Linux <linux@....linux.org.uk> To: Joel Fernandes <joelf@...com> Cc: dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org, davinci-linux-open-source@...ux.davincidsp.com, Vinod Koul <vinod.koul@...el.com>, Dan Williams <dan.j.williams@...el.com> Subject: Re: [PATCH] [FIX] dmaengine: virt-dma: Free descriptor after callback On Thu, Apr 17, 2014 at 07:56:50PM -0500, Joel Fernandes wrote: > Free the vd (virt descriptor) after the callback is called. In EDMA driver > atleast which uses virt-dma, we make use of the desc during the callback and if > its dangerously freed before the callback is called. I also noticed this in > omap-dma dmaengine driver. You've missed the vital bit of information: why do you make use of the descriptor afterwards? You shouldn't. omap-dma doesn't either. Once clients submit their request to DMA engine, they must not hold any kind of reference to the descriptor other than the cookie. -- FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly improving, and getting towards what was expected from it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists