linux-kernel - Re: [PATCH] regulator: Allow set voltage on fixed regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Apr 2014 19:52:25 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Tim Kryger <tim.kryger@...aro.org>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: Allow set voltage on fixed regulators

On Fri, Apr 18, 2014 at 11:30:10AM -0700, Tim Kryger wrote:
> If a regulator consumer requests a voltage range that can be satisfied,
> the return value should indicate success even if that regulator has a
> fixed voltage.  Since there is already logic to check if the requested
> voltage range overlaps the allowed range, set REGULATOR_CHANGE_VOLTAGE
> for regulators with constraints that include a positive voltage.

This seems like the wrong place to fix this, it's nothing to do with DT
and we shouldn't require that nonsensical permissions are set.  Instead
we should fix this at the point where we're implementing the permission
check, have the failure case check the current voltage before returning
an error.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)