[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <535541DA.8040601@samba.org>
Date: Mon, 21 Apr 2014 18:05:46 +0200
From: "Stefan (metze) Metzmacher" <metze@...ba.org>
To: Jeff Layton <jlayton@...hat.com>, linux-fsdevel@...r.kernel.org
CC: linux-kernel@...r.kernel.org, samba-technical@...ts.samba.org,
Ganesha NFS List <nfs-ganesha-devel@...ts.sourceforge.net>,
Carlos O'Donell <carlos@...hat.com>,
libc-alpha <libc-alpha@...rceware.org>,
Michael Kerrisk <mtk.manpages@...il.com>
Subject: Re: [PATCH] locks: rename file-private locks to file-description
locks
Am 21.04.2014 15:45, schrieb Jeff Layton:
> File-private locks have been merged into Linux for v3.15, and *now*
> people are commenting that the name and macro definitions for the new
> file-private locks suck.
>
> ...and I can't even disagree. The names and command macros do suck.
>
> We're going to have to live with these for a long time, so it's
> important that we be happy with the names before we're stuck with them.
>
> The consensus on the lists so far is that they should be rechristened as
> "file-description locks".
>
> This patch makes the following changes that I think are necessary before
> v3.15 ships:
>
> 1) rename the command macros to their new names. These end up in the uapi
> headers and so are part of the external-facing API. It turns out that
> glibc doesn't actually use the fcntl.h uapi header, but it's hard to
> be sure that something else won't. Changing it now is safest.
>
> 2) make the the /proc/locks output display these as type "FDLOCK"
>
> The rest of the renaming can wait until v3.16, since everything else
> isn't visible outside of the kernel.
>
> Cc: Michael Kerrisk <mtk.manpages@...il.com>
> Signed-off-by: Jeff Layton <jlayton@...hat.com>
Reviewed-by: Stefan Metzmacher <metze@...ba.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists