linux-kernel - Re: [PATCH] rtlwifi: rtl8188ee: initialize packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53555240.70806@lwfinger.net>
Date:	Mon, 21 Apr 2014 12:15:44 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Colin King <colin.king@...onical.com>,
	Chaoming Li <chaoming_li@...lsil.com.cn>,
	"John W. Linville" <linville@...driver.com>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtlwifi: rtl8188ee: initialize packet_beacon

On 04/21/2014 11:38 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> static code analysis from cppcheck reports:
>
> [drivers/net/wireless/rtlwifi/rtl8188ee/trx.c:322]:
>    (error) Uninitialized variable: packet_beacon
>
> packet_beacon is not initialized and hence packet_beacon
> contains garbage from the stack, so set it to false.
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>   drivers/net/wireless/rtlwifi/rtl8188ee/trx.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

This change should have a "Cc: Stable <stable@...r.kernel.org> [3.10+] notation.

Other than that, Acked-by: Larry Finger <Larry.Finger@...inger.net>

John: Is it possible for you to add stable, or do you want Colin to resubmit.

Larry

>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c b/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c
> index 06ef47c..5b4c225 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8188ee/trx.c
> @@ -293,7 +293,7 @@ static void _rtl88ee_translate_rx_signal_stuff(struct ieee80211_hw *hw,
>   	u8 *psaddr;
>   	__le16 fc;
>   	u16 type, ufc;
> -	bool match_bssid, packet_toself, packet_beacon, addr;
> +	bool match_bssid, packet_toself, packet_beacon = false, addr;
>
>   	tmp_buf = skb->data + pstatus->rx_drvinfo_size + pstatus->rx_bufshift;
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/