linux-kernel - Re: [PATCH] rtlwifi: rtl8188ee: initialize packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140422175919.GC16193@tuxdriver.com>
Date:	Tue, 22 Apr 2014 13:59:19 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	Colin King <colin.king@...onical.com>,
	Chaoming Li <chaoming_li@...lsil.com.cn>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtlwifi: rtl8188ee: initialize packet_beacon

On Mon, Apr 21, 2014 at 12:15:44PM -0500, Larry Finger wrote:
> On 04/21/2014 11:38 AM, Colin King wrote:
> >From: Colin Ian King <colin.king@...onical.com>
> >
> >static code analysis from cppcheck reports:
> >
> >[drivers/net/wireless/rtlwifi/rtl8188ee/trx.c:322]:
> >   (error) Uninitialized variable: packet_beacon
> >
> >packet_beacon is not initialized and hence packet_beacon
> >contains garbage from the stack, so set it to false.
> >
> >Signed-off-by: Colin Ian King <colin.king@...onical.com>
> >---
> >  drivers/net/wireless/rtlwifi/rtl8188ee/trx.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> This change should have a "Cc: Stable <stable@...r.kernel.org> [3.10+] notation.
> 
> Other than that, Acked-by: Larry Finger <Larry.Finger@...inger.net>
> 
> John: Is it possible for you to add stable, or do you want Colin to resubmit.

Got it, thanks...

-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/