[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140422060654.GB9133@gmail.com>
Date: Tue, 22 Apr 2014 08:06:54 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Jianyu Zhan <nasa4836@...il.com>
Cc: a.p.zijlstra@...llo.nl, paulus@...ba.org, mingo@...hat.com,
acme@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf-event/cgroup: explicitly init the early_init field
* Jianyu Zhan <nasa4836@...il.com> wrote:
> For a cgroup subsystem who should init early, then it should carefully
> take care of the implementation of css_alloc, because it will be called
> before mm_init() setup the world.
>
> Luckily we don't, and we better explicitly assign the early_init field
> to 0, for document reason.
>
> Signed-off-by: Jianyu Zhan <nasa4836@...il.com>
> ---
> kernel/events/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index f83a71a..b3a8916 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -8062,5 +8062,6 @@ struct cgroup_subsys perf_event_cgrp_subsys = {
> .css_free = perf_cgroup_css_free,
> .exit = perf_cgroup_exit,
> .attach = perf_cgroup_attach,
> + .early_init = 0,
How can that field ever be nonzero?
I.e. under what exact circumstances does this patch make sense?
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists