linux-kernel - Re: [PATCH 1/3] 6lowpan: add helper to get 6lowpan namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140422175818.GN27882@wotan.suse.de>
Date:	Tue, 22 Apr 2014 19:58:18 +0200
From:	"Luis R. Rodriguez" <mcgrof@...e.com>
To:	Alexander Aring <alex.aring@...il.com>
Cc:	Johannes Berg <johannes@...solutions.net>,
	"Luis R. Rodriguez" <mcgrof@...not-panic.com>,
	alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com,
	linux-zigbee-devel@...ts.sourceforge.net, davem@...emloft.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	backports@...r.kernel.org
Subject: Re: [PATCH 1/3] 6lowpan: add helper to get 6lowpan namespace

On Tue, Apr 22, 2014 at 11:53:03AM +0200, Alexander Aring wrote:
> Hi,
> 
> On Tue, Apr 22, 2014 at 11:44:46AM +0200, Johannes Berg wrote:
> > On Thu, 2014-04-17 at 18:22 -0700, Luis R. Rodriguez wrote:
> > 
> > > +#if IS_ENABLED(CONFIG_IEEE802154_6LOWPAN)
> > > [...]
> > > +#else
> > > +static inline struct netns_ieee802154_lowpan *
> > > +net_ieee802154_lowpan(struct net *net)
> > > +{
> > > +	return NULL;
> > > +}
> > > +#endif
> > 
> > Why would that be needed? If nobody compiles 802.15.4 then it seems
> > nothing should reference it?
> > 
> Indeed I think this is unnecessary, also.

I wanted to be sure, and I was not. Right now 6lowpan does not depend
on CONFIG_NET_NS, is this intentional? I think its fine without it
but I was not sure.

  Luis

Content of type "application/pgp-signature" skipped