| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAAYSxhrzX+bW-94RForJqJQ7K9BtXvUoNz9KC7XBWwACsx7qPA@mail.gmail.com> Date: Tue, 22 Apr 2014 11:38:38 -0700 From: Tim Kryger <tim.kryger@...aro.org> To: Mark Brown <broonie@...nel.org> Cc: Liam Girdwood <lgirdwood@...il.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] regulator: Allow set voltage on fixed regulators On Fri, Apr 18, 2014 at 11:52 AM, Mark Brown <broonie@...nel.org> wrote: > On Fri, Apr 18, 2014 at 11:30:10AM -0700, Tim Kryger wrote: >> If a regulator consumer requests a voltage range that can be satisfied, >> the return value should indicate success even if that regulator has a >> fixed voltage. Since there is already logic to check if the requested >> voltage range overlaps the allowed range, set REGULATOR_CHANGE_VOLTAGE >> for regulators with constraints that include a positive voltage. > > This seems like the wrong place to fix this, it's nothing to do with DT > and we shouldn't require that nonsensical permissions are set. Instead > we should fix this at the point where we're implementing the permission > check, have the failure case check the current voltage before returning > an error. I now see that Bjorn submitted a patch which did exactly that. https://lkml.org/lkml/2014/2/5/494 His change made it into v3.15-rc1, so mine is no longer necessary. Thanks, Tim Kryger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists