| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Apr 2014 10:28:39 +0300 From: Mika Westerberg <mika.westerberg@...ux.intel.com> To: Lan Tianyu <tianyu.lan@...el.com> Cc: wsa@...-dreams.de, rjw@...ysocki.net, awilliam@...hat.com, lenb@...nel.org, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org Subject: Re: [Resend Patch 7/9] I2C/ACPI: Add i2c ACPI operation region support On Wed, Apr 23, 2014 at 09:53:21AM +0800, Lan Tianyu wrote: > Hi Mika: > Thanks a lot for your review. > > On 2014年04月22日 19:36, Mika Westerberg wrote: > >> > + > >> > + client.adapter = adapter; > >> > + client.addr = sb->slave_address; > >> > + client.flags = 0; > > I'm not sure if this is the correct way to use struct i2c_client > > (allocating it from stack and passing forward to functions that might > > expect a real i2c_client structure). It has ->dev and all. > > I check all i2c_smbus_xxx helper functions and they are simple wrappers > of i2c_smbus_xfer(). Only adapter, addr and flags of struct client are > used in these functions. In that case I suppose it is OK to (ab)use the client structure like this. I think you still want to initialize the whole structure (unused fields with zero) before passing it to the wrappers. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists