linux-kernel - Re: [PATCH v6 15/19] usb: phy: msm: Fix PTS definitions for MSM USB controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1398261183.4724.226.camel@iivanov-dev>
Date:	Wed, 23 Apr 2014 16:53:03 +0300
From:	"Ivan T. Ivanov" <iivanov@...sol.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Felipe Balbi <balbi@...com>, Tim Bird <tbird20d@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, Tim Bird <tim.bird@...ymobile.com>
Subject: Re: [PATCH v6 15/19] usb: phy: msm: Fix PTS definitions for MSM USB
 controller

On Wed, 2014-04-23 at 17:45 +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 23-04-2014 17:35, Ivan T. Ivanov wrote:
> 
> >>>> --- a/include/linux/usb/msm_hsusb_hw.h
> >>>> +++ b/include/linux/usb/msm_hsusb_hw.h
> >>>> @@ -31,8 +31,9 @@
> >>>>    #define USB_USBINTR          (MSM_USB_BASE + 0x0148)
> >>>>
> >>>>    #define PORTSC_PHCD            (1 << 23) /* phy suspend mode */
> >>>> -#define PORTSC_PTS_MASK         (3 << 30)
> >>>> -#define PORTSC_PTS_ULPI         (3 << 30)
> >>>> +#define PORTSC_PTS_MASK        (3 << 30)
> >>>> +#define PORTSC_PTS_ULPI        (2 << 30)
> >>>> +#define PORTSC_PTS_SERIAL      (3 << 30)
> 
> >>>      Please use tabs, not spaces here.
> 
> >> Thanks, will fix and resend.
> 
> > I answered too quickly. File contain tabs and spaces for
> > indentation of definitions.
> 
>     You mean tabs and spaces on one line? Or sometimes tabs, sometimes spaces?

In this particular hunk, original code uses spaces.

Ivan

> 
> > Should I still use tabs here?
> 
>     If they are already used, why not?
> 
> > Regards,
> > Ivan
> 
> WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/