[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5357C99F.6070009@cogentembedded.com>
Date: Wed, 23 Apr 2014 18:09:35 +0400
From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To: "Ivan T. Ivanov" <iivanov@...sol.com>
CC: Felipe Balbi <balbi@...com>, Tim Bird <tbird20d@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, Tim Bird <tim.bird@...ymobile.com>
Subject: Re: [PATCH v6 15/19] usb: phy: msm: Fix PTS definitions for MSM USB
controller
On 23-04-2014 17:53, Ivan T. Ivanov wrote:
>>>>>> --- a/include/linux/usb/msm_hsusb_hw.h
>>>>>> +++ b/include/linux/usb/msm_hsusb_hw.h
>>>>>> @@ -31,8 +31,9 @@
>>>>>> #define USB_USBINTR (MSM_USB_BASE + 0x0148)
>>>>>>
>>>>>> #define PORTSC_PHCD (1 << 23) /* phy suspend mode */
>>>>>> -#define PORTSC_PTS_MASK (3 << 30)
>>>>>> -#define PORTSC_PTS_ULPI (3 << 30)
>>>>>> +#define PORTSC_PTS_MASK (3 << 30)
>>>>>> +#define PORTSC_PTS_ULPI (2 << 30)
>>>>>> +#define PORTSC_PTS_SERIAL (3 << 30)
>>>>> Please use tabs, not spaces here.
>>>> Thanks, will fix and resend.
>>> I answered too quickly. File contain tabs and spaces for
>>> indentation of definitions.
>> You mean tabs and spaces on one line? Or sometimes tabs, sometimes spaces?
> In this particular hunk, original code uses spaces.
That I saw. 8-)
I was asking about this file in general.
> Ivan
>>> Should I still use tabs here?
>> If they are already used, why not?
>>> Regards,
>>> Ivan
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists