linux-kernel - Re: [PATCH 1/3] crypto: Fix potential leak in test_aead_speed() if aad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140423194335.2d72d7a4@spike>
Date:	Wed, 23 Apr 2014 19:43:35 +0200
From:	Christian Engelmayer <cengelma@....at>
To:	Marek Vasut <marex@...x.de>
Cc:	tim.c.chen@...ux.intel.com, herbert@...dor.apana.org.au,
	davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] crypto: Fix potential leak in test_aead_speed() if
 aad_size is too big

On Wed, 23 Apr 2014 01:33:05 +0200, Marek Vasut <marex@...x.de> wrote:
> On Monday, April 21, 2014 at 08:45:59 PM, Christian Engelmayer wrote:
> > +	if (aad_size >= PAGE_SIZE) {
> 
> On an unrelated note ... Won't if (aad_size > PAGE_SIZE) be sufficient here?

From what I have seen how the buffers are allocated via __get_free_page() I
thought so too. However, as it previously read

	if (aad_size < PAGE_SIZE)
		memset(assoc, 0xff, aad_size);
	else {

my intention was simply to make the modification so that the bug is addressed
without introducing an additional change.

Regards,
Christian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)