linux-kernel - Re: [PATCH 1/3] crypto: Fix potential leak in test_aead_speed() if aad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201404231944.41781.marex@denx.de>
Date:	Wed, 23 Apr 2014 19:44:41 +0200
From:	Marek Vasut <marex@...x.de>
To:	Christian Engelmayer <cengelma@....at>
Cc:	tim.c.chen@...ux.intel.com, herbert@...dor.apana.org.au,
	davem@...emloft.net, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] crypto: Fix potential leak in test_aead_speed() if aad_size is too big

On Wednesday, April 23, 2014 at 07:43:35 PM, Christian Engelmayer wrote:
> On Wed, 23 Apr 2014 01:33:05 +0200, Marek Vasut <marex@...x.de> wrote:
> > On Monday, April 21, 2014 at 08:45:59 PM, Christian Engelmayer wrote:
> > > +	if (aad_size >= PAGE_SIZE) {
> > 
> > On an unrelated note ... Won't if (aad_size > PAGE_SIZE) be sufficient
> > here?
> 
> From what I have seen how the buffers are allocated via __get_free_page() I
> thought so too. However, as it previously read
> 
> 	if (aad_size < PAGE_SIZE)
> 		memset(assoc, 0xff, aad_size);
> 	else {
> 
> my intention was simply to make the modification so that the bug is
> addressed without introducing an additional change.

I fully agree with you. I was just curious about the comparison here.

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/