lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140423190015.GF25378@pd.tnic>
Date:	Wed, 23 Apr 2014 21:00:15 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	linux-kernel@...r.kernel.org, peterz@...radead.org, mingo@...e.hu,
	venkateshs@...gle.com, ak@...ux.intel.com, zheng.z.yan@...el.com
Subject: Re: [PATCH] perf/x86: fix RAPL rdmsrl_safe() usage

On Wed, Apr 23, 2014 at 07:04:19PM +0200, Stephane Eranian wrote:
> 
> This patch fixes a bug introduced by commit 24223657.

Maybe add

Fixes: <commit-id>

tag?

> The rdmsrl_safe() function returns 0 on success.
> The current code was failing to detect the RAPL PMU
> on real hardware  (missing /sys/devices/power) because
> the return value of rdmsrl_safe() was misinterpreted.
> 
> Signed-off-by: Stephane Eranian <eranian@...gle.com>

Acked-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ