[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140423192228.GY8488@redhat.com>
Date: Wed, 23 Apr 2014 15:22:28 -0400
From: Don Zickus <dzickus@...hat.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
davem@...emloft.net, sparclinux@...r.kernel.org, mguzik@...hat.com
Subject: Re: [PATCH 0/4 V3] Print traces on softlockup
On Tue, Apr 22, 2014 at 11:28:28AM -0700, Andrew Morton wrote:
> On Tue, 22 Apr 2014 11:17:24 -0400 Don Zickus <dzickus@...hat.com> wrote:
>
> > Added more patches to handle the 'uniprocessor' panic case by sending NMIs
> > to every cpu but self. Only affects x86, sparc.
> >
>
> Looks OK to me. A couple of things:
>
> - Patches 1-3 should be combined so we don't create bisection holes
> due to x86 and sparc build errors.
>
> - Patch 4 adds stuff which is unusable on uniprocessor, especially
> the presence of /proc/sys/kernel/softlockup_all_cpu_backtrace. We
> already have #ifdef CONFIG_SMP in kern_table, so do more of that?
Are you suggesting just add CONFIG_SMP to kern_table entry or all the
pieces in kernel/watchdog.c too? I wasn't sure how messy I should make
this patch.
Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists