linux-kernel - RE: [PATCH V1 net-next 1/1] hyperv: Enable sendbuf mechanism on the send path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Apr 2014 22:06:24 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Andev <debiandev@...il.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"apw@...onical.com" <apw@...onical.com>,
	"jasowang@...hat.com" <jasowang@...hat.com>
Subject: RE: [PATCH V1 net-next 1/1] hyperv: Enable sendbuf mechanism on the
 send path



> -----Original Message-----
> From: Andev [mailto:debiandev@...il.com]
> Sent: Thursday, April 24, 2014 2:50 PM
> To: KY Srinivasan
> Cc: davem@...emloft.net; netdev@...r.kernel.org; LKML;
> devel@...uxdriverproject.org; olaf@...fle.de; apw@...onical.com;
> jasowang@...hat.com
> Subject: Re: [PATCH V1 net-next 1/1] hyperv: Enable sendbuf mechanism on
> the send path
> 
> On Wed, Apr 23, 2014 at 5:24 PM, K. Y. Srinivasan <kys@...rosoft.com>
> wrote:
> 
> >  drivers/net/hyperv/hyperv_net.h |   14 +++
> >  drivers/net/hyperv/netvsc.c     |  226
> +++++++++++++++++++++++++++++++++++++--
> >  drivers/net/hyperv/netvsc_drv.c |    3 +->  3 files changed, 234
> insertions(+), 9 deletions(-)
> 
> I just looked over netvsc.c and it could definitely use a more consistent
> coding style.
> 
> Your use of goto exit/cleanup in some functions and returning directly on
> errors in others could use a cleanup. Please consider doing that while you are
> touching those files.

Will do. The most recent changes I made to netvsc.c, I think was consistent with the existing code;
going forward we will certainly move towards a more consistent coding style.

Regards,

K. Y