lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Apr 2014 17:49:41 -0400 From: Andev <debiandev@...il.com> To: "K. Y. Srinivasan" <kys@...rosoft.com> Cc: davem@...emloft.net, netdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, devel@...uxdriverproject.org, olaf@...fle.de, apw@...onical.com, jasowang@...hat.com Subject: Re: [PATCH V1 net-next 1/1] hyperv: Enable sendbuf mechanism on the send path On Wed, Apr 23, 2014 at 5:24 PM, K. Y. Srinivasan <kys@...rosoft.com> wrote: > drivers/net/hyperv/hyperv_net.h | 14 +++ > drivers/net/hyperv/netvsc.c | 226 +++++++++++++++++++++++++++++++++++++-- > drivers/net/hyperv/netvsc_drv.c | 3 +-> 3 files changed, 234 insertions(+), 9 deletions(-) I just looked over netvsc.c and it could definitely use a more consistent coding style. Your use of goto exit/cleanup in some functions and returning directly on errors in others could use a cleanup. Please consider doing that while you are touching those files. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists