linux-kernel - Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1398346899.1681.18.camel@leonhard>
Date:	Thu, 24 Apr 2014 22:41:39 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Don Zickus <dzickus@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Jiri Olsa <jolsa@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCHSET 00/17] perf report: Add -F option for specifying
 output fields (v4)

Hi Don,

2014-04-23 (수), 08:58 -0400, Don Zickus:
> On Wed, Apr 23, 2014 at 03:15:35PM +0900, Namhyung Kim wrote:
> > On Tue, 22 Apr 2014 17:16:47 -0400, Don Zickus wrote:
> > > ./perf mem record -a grep -r foo /* > /dev/null
> > > ./perf mem report -F overhead,symbol_daddr,pid -s symbol_daddr,pid --stdio 
> > >
> > > I was thinking I could sort everything based on the symbol_daddr and pid.
> > > Then re-sort the output to display the highest 'symbol_daddr,pid' pair.
> > > But it didn't seem to work that way.  Instead it seems like I get the
> > > original sort just displayed in the -F format.
> > 
> > Could you please show me the output of your example?
> 
> 
> # To display the perf.data header info, please use --header/--header-only
> # options.
> #
> # Samples: 96K of event 'cpu/mem-loads/pp'
> # Total weight : 1102938
> # Sort order   : symbol_daddr,pid
> #
> # Overhead Data Symbol          Command:  Pid
> # ........ ......................................................................
> #
>      0.00%  [k] 0xffff8807a8c1cf80 grep:116437
>      0.00%  [k] 0xffff8807a8c8cee0 grep:116437
>      0.00%  [k] 0xffff8807a8dceea0 grep:116437
>      0.01%  [k] 0xffff8807a9298dc0 grep:116437
>      0.01%  [k] 0xffff8807a934be40 grep:116437
>      0.00%  [k] 0xffff8807a9416ec0 grep:116437
>      0.02%  [k] 0xffff8807a9735700 grep:116437
>      0.00%  [k] 0xffff8807a98e9460 grep:116437
>      0.02%  [k] 0xffff8807a9afc890 grep:116437
>      0.00%  [k] 0xffff8807aa64feb0 grep:116437
>      0.02%  [k] 0xffff8807aa6b0030 grep:116437

Hmm.. it seems that it's exactly sorted by the data symbol addresses, so
I don't see any problem here.  What did you expect?  If you want to see
those symbol_daddr,pid pair to be sorted by overhead, you can use the
one of -F or -s option only.

IOW, "perf mem report -F overhead,symbol_daddr,pid" and "perf mem report
-s symbol_daddr,pid" should show same result.  FYI but "perf mem report
-F overhead,symbol_daddr,pid -s symbol_addr,pid" will be different.

It's due to a compatibility reason.  If -s option is used without -F
option, it'll prepend 'overhead' sort key to preserve old behavior (adds
the fields to output but sort by overhead only).

Thanks,
Namhyung


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/