linux-kernel - Re: [PATCH V2] ASoC: SAMSUNG: Add sound card driver for Snow board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140424133920.GA12304@sirena.org.uk>
Date:	Thu, 24 Apr 2014 14:39:20 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Tushar Behera <tushar.behera@...aro.org>
Cc:	alsa-devel@...a-project.org, linux-samsung-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	devicetree@...r.kernel.org, lgirdwood@...il.com,
	robh+dt@...nel.org, sbkim73@...sung.com, rdunlap@...radead.org,
	dianders@...omium.org
Subject: Re: [PATCH V2] ASoC: SAMSUNG: Add sound card driver for Snow board

On Wed, Apr 23, 2014 at 02:31:45PM +0530, Tushar Behera wrote:

> +Required properties:
> +- compatible : Can be one of the following,
> +			"google,snow-audio-max98090" or
> +			"google,snow-audio-max98095"
> +- samsung,i2s-controller: The phandle of the Samsung I2S0 controller

This should be any I2S controller, not just I2S0?

> +- samsung,audio-codec: The phandle of the audio codec

This binding only has one I2S controller and CODEC.  However...

> +static struct snd_soc_dai_link snow_dai[] = {
> +	{ /* Playback DAI i/f */
> +		.name = "Playback",
> +		.stream_name = "Playback",
> +		.codec_dai_name = "HiFi",
> +		.dai_fmt = SND_SOC_DAIFMT_I2S |
> +				SND_SOC_DAIFMT_NB_NF |
> +				SND_SOC_DAIFMT_CBS_CFS,
> +	}, { /* Capture DAI i/f */
> +		.name = "Capture",
> +		.stream_name = "Capture",
> +		.codec_dai_name = "HiFi",
> +		.dai_fmt = SND_SOC_DAIFMT_I2S |
> +				SND_SOC_DAIFMT_NB_NF |
> +				SND_SOC_DAIFMT_CBS_CFS,
> +	},
> +};

...for some reason we have separate capture and playback DAI links
defined.  Why is that?  Also, why is the secondary I2S playback stream
not supported (this may be a reason to restrict to only the one I2S
interface)?

Please also use subject lines consistent with the subsystem - NO NEED TO
SHOUT.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)