linux-kernel - Re: [PATCH V2] ASoC: SAMSUNG: Add sound card driver for Snow board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5359E18B.60600@linaro.org>
Date:	Fri, 25 Apr 2014 09:46:11 +0530
From:	Tushar Behera <tushar.behera@...aro.org>
To:	Mark Brown <broonie@...nel.org>
CC:	alsa-devel@...a-project.org, linux-samsung-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	devicetree@...r.kernel.org, lgirdwood@...il.com,
	robh+dt@...nel.org, sbkim73@...sung.com, rdunlap@...radead.org,
	dianders@...omium.org
Subject: Re: [PATCH V2] ASoC: SAMSUNG: Add sound card driver for Snow board

On 04/24/2014 07:09 PM, Mark Brown wrote:
> On Wed, Apr 23, 2014 at 02:31:45PM +0530, Tushar Behera wrote:
> 
>> +Required properties:
>> +- compatible : Can be one of the following,
>> +			"google,snow-audio-max98090" or
>> +			"google,snow-audio-max98095"
>> +- samsung,i2s-controller: The phandle of the Samsung I2S0 controller
> 
> This should be any I2S controller, not just I2S0?
> 

Yes, right. It can be any I2S controller. Just that, right now it is
wired to I2S0.

>> +- samsung,audio-codec: The phandle of the audio codec
> 
> This binding only has one I2S controller and CODEC.  However...
> 
>> +static struct snd_soc_dai_link snow_dai[] = {
>> +	{ /* Playback DAI i/f */
>> +		.name = "Playback",
>> +		.stream_name = "Playback",
>> +		.codec_dai_name = "HiFi",
>> +		.dai_fmt = SND_SOC_DAIFMT_I2S |
>> +				SND_SOC_DAIFMT_NB_NF |
>> +				SND_SOC_DAIFMT_CBS_CFS,
>> +	}, { /* Capture DAI i/f */
>> +		.name = "Capture",
>> +		.stream_name = "Capture",
>> +		.codec_dai_name = "HiFi",
>> +		.dai_fmt = SND_SOC_DAIFMT_I2S |
>> +				SND_SOC_DAIFMT_NB_NF |
>> +				SND_SOC_DAIFMT_CBS_CFS,
>> +	},
>> +};
> 
> ...for some reason we have separate capture and playback DAI links

That was lack of understanding from my side. I was of the impression
that the back-end uses different DAI interfaces for aplay and arecord,
which certainly is not the case. I will remove the 'Capture' dai and
make 'Playback' dai as the primary DAI.

> defined.  Why is that?  Also, why is the secondary I2S playback stream
> not supported (this may be a reason to restrict to only the one I2S
> interface)?

AFAICS, I2S driver doesn't support secondary DAI with DT (dai type is
always TYPE_PRI in case of DT). Hence I could not find a setup to test
secondary dai with this board.

> 
> Please also use subject lines consistent with the subsystem - NO NEED TO
> SHOUT.
> 

Noted, will take care.

Thanks.
-- 
Tushar Behera
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/