linux-kernel - Re: [PATCH 16/28] nios2: System calls handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Apr 2014 00:23:21 +0800
From:	Ley Foon Tan <lftan@...era.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Linux-Arch <linux-arch@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	cltang@...esourcery.com
Subject: Re: [PATCH 16/28] nios2: System calls handling

On Tue, Apr 22, 2014 at 8:30 PM, Arnd Bergmann <arnd@...db.de> wrote:
> On Friday 18 April 2014, Ley Foon Tan wrote:
>
>> +
>> + #define sys_mmap2 sys_mmap_pgoff
>> +
>
> You use sys_mmap_pgoff here, but
>
>> +asmlinkage long sys_mmap(unsigned long addr, unsigned long len,
>> +                     unsigned long prot, unsigned long flags,
>> +                     unsigned long fd, unsigned long offset)
>> +{
>> +     if (offset & ~PAGE_MASK)
>> +             return -EINVAL;
>> +
>> +     return sys_mmap_pgoff(addr, len, prot, flags, fd, offset >> PAGE_SHIFT);
>> +}
>
> define a separate sys_mmap() here. Doing the former should be enough.
> so you can just drop the sys_mmap definition.
Okay, will drop the sys_mmap.

Thanks.
Regards
Ley Foon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/