linux-kernel - Re: [PATCH] drm/tilcdc: restore correct display mode and contents on pm resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140424175817.GB4659@saruman.home>
Date:	Thu, 24 Apr 2014 12:58:17 -0500
From:	Felipe Balbi <balbi@...com>
To:	Felipe Balbi <balbi@...com>
CC:	<airlied@...ux.ie>, <airlied@...hat.com>, <robdclark@...il.com>,
	<bparrot@...com>, <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Darren Etheridge <detheridge@...com>
Subject: Re: [PATCH] drm/tilcdc: restore correct display mode and contents on
 pm resume

On Mon, Mar 03, 2014 at 01:08:56PM -0600, Felipe Balbi wrote:
> From: Darren Etheridge <detheridge@...com>
> 
> On resume the screen contents were not being restored properly.  Looking at
> other DRM drivers it seems a call to drm_helper_resume_force_mode() is needed
> in the resume handler to force restoration of the mode and framebuffer data.
> 
> Signed-off-by: Darren Etheridge <detheridge@...com>

ping

> ---
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 171a820..1a5ddfa 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -563,6 +563,13 @@ static int tilcdc_pm_resume(struct device *dev)
>  		if (registers[i].save && (priv->rev >= registers[i].rev))
>  			tilcdc_write(ddev, registers[i].reg, priv->saved_register[n++]);
>  
> +	/*
> +	 * if this call isn't here, the display is blank on return from
> +	 * suspend.  With this call here the contents of the framebuffer
> +	 * during suspend are restored correctly.
> +	 */
> +	drm_helper_resume_force_mode(ddev);
> +
>  	drm_kms_helper_poll_enable(ddev);
>  
>  	return 0;
> -- 
> 1.9.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)