linux-kernel - Re: [PATCH] drm/tilcdc: restore correct display mode and contents on pm resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF6AEGvBt=KVk5q2DNhOrkZ=ZiG=V9SdEDDsDj69Z0phAa30+Q@mail.gmail.com>
Date:	Thu, 24 Apr 2014 16:48:48 -0400
From:	Rob Clark <robdclark@...il.com>
To:	Felipe Balbi <balbi@...com>
Cc:	David Airlie <airlied@...ux.ie>,
	"airlied@...hat.com" <airlied@...hat.com>,
	Benoit Parrot <bparrot@...com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Darren Etheridge <detheridge@...com>
Subject: Re: [PATCH] drm/tilcdc: restore correct display mode and contents on
 pm resume

On Mon, Mar 3, 2014 at 2:08 PM, Felipe Balbi <balbi@...com> wrote:
> From: Darren Etheridge <detheridge@...com>
>
> On resume the screen contents were not being restored properly.  Looking at
> other DRM drivers it seems a call to drm_helper_resume_force_mode() is needed
> in the resume handler to force restoration of the mode and framebuffer data.
>
> Signed-off-by: Darren Etheridge <detheridge@...com>

Reviewed-by: Rob Clark <robdclark@...il.com>

> ---
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 171a820..1a5ddfa 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -563,6 +563,13 @@ static int tilcdc_pm_resume(struct device *dev)
>                 if (registers[i].save && (priv->rev >= registers[i].rev))
>                         tilcdc_write(ddev, registers[i].reg, priv->saved_register[n++]);
>
> +       /*
> +        * if this call isn't here, the display is blank on return from
> +        * suspend.  With this call here the contents of the framebuffer
> +        * during suspend are restored correctly.
> +        */
> +       drm_helper_resume_force_mode(ddev);
> +
>         drm_kms_helper_poll_enable(ddev);
>
>         return 0;
> --
> 1.9.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/