| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.DEB.2.10.1404241712310.9220@vincent-weaver-1.umelst.maine.edu> Date: Thu, 24 Apr 2014 17:14:40 -0400 (EDT) From: Vince Weaver <vincent.weaver@...ne.edu> To: Peter Zijlstra <peterz@...radead.org> cc: linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>, Thomas Gleixner <tglx@...utronix.de> Subject: Re: [perf] yet another 32/64-bit range check failure On Wed, 23 Apr 2014, Peter Zijlstra wrote: > > Something like so should do I suppose. > > --- > Subject: perf: Fix perf_event_open(.flags) test > > Vince noticed that we test the (unsigned long) flags field against an > (unsigned int) constant. This would allow setting the high bits on 64bit > platforms and not get an error. > > There is nothing that uses the high bits, so it should be entirely > harmless, but we don't want userspace to accidentally set them anyway, > so fix the constants. > > Reported-by: Vince Weaver <vincent.weaver@...ne.edu> > Signed-off-by: Peter Zijlstra <peterz@...radead.org> Tested-by: Vince Weaver <vincent.weaver@...ne.edu> Your patch fixes the problem, or at least the test I wrote to check the issue now fails properly. Oddly, with this patch applied, it's made it a lot harder (but not impossible) to trigger the memory corruption bug, although that might just be coincidence. Vince -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists