linux-kernel - Re: [PATCH] staging: silicom: Add appropriate ifdef conditions in bpctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140425223356.GA7045@kroah.com>
Date:	Fri, 25 Apr 2014 15:33:56 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Daeseok Youn <daeseok.youn@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	tulinizer@...il.com, viro@...iv.linux.org.uk, lorenz@...gers.com
Subject: Re: [PATCH] staging: silicom: Add appropriate ifdef conditions in
 bpctl_mod.c

On Mon, Apr 07, 2014 at 12:03:41PM +0900, Daeseok Youn wrote:
> 
> The bp_proc_create() can be called if BP_PROC_SUPPORT is defined.
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
> ---
>  drivers/staging/silicom/bpctl_mod.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c
> index 6b9365b..5a3d758 100644
> --- a/drivers/staging/silicom/bpctl_mod.c
> +++ b/drivers/staging/silicom/bpctl_mod.c
> @@ -119,7 +119,10 @@ static void if_scan_init(void);
>  
>  static int bypass_proc_create_dev_sd(struct bpctl_dev *pbp_device_block);
>  static int bypass_proc_remove_dev_sd(struct bpctl_dev *pbp_device_block);
> +
> +#ifdef BP_PROC_SUPPORT
>  static int bp_proc_create(void);
> +#endif

No, this code should just be removed, right?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/