linux-kernel - Re: [PATCH] staging: silicom: Add appropriate ifdef conditions in bpctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHb8M2C0JM9Qdio6ni87VOj12M15GUZV3KZjAeV2ZsVyFp7Nzg@mail.gmail.com>
Date:	Sat, 26 Apr 2014 09:26:45 +0900
From:	DaeSeok Youn <daeseok.youn@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	tulinizer@...il.com, viro@...iv.linux.org.uk, lorenz@...gers.com
Subject: Re: [PATCH] staging: silicom: Add appropriate ifdef conditions in bpctl_mod.c

2014-04-26 7:33 GMT+09:00, Greg KH <gregkh@...uxfoundation.org>:
> On Mon, Apr 07, 2014 at 12:03:41PM +0900, Daeseok Youn wrote:
>>
>> The bp_proc_create() can be called if BP_PROC_SUPPORT is defined.
>>
>> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
>> ---
>>  drivers/staging/silicom/bpctl_mod.c |    5 +++++
>>  1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/staging/silicom/bpctl_mod.c
>> b/drivers/staging/silicom/bpctl_mod.c
>> index 6b9365b..5a3d758 100644
>> --- a/drivers/staging/silicom/bpctl_mod.c
>> +++ b/drivers/staging/silicom/bpctl_mod.c
>> @@ -119,7 +119,10 @@ static void if_scan_init(void);
>>
>>  static int bypass_proc_create_dev_sd(struct bpctl_dev
>> *pbp_device_block);
>>  static int bypass_proc_remove_dev_sd(struct bpctl_dev
>> *pbp_device_block);
>> +
>> +#ifdef BP_PROC_SUPPORT
>>  static int bp_proc_create(void);
>> +#endif
>
> No, this code should just be removed, right?
Yes, someone sent a patch for this.

Regards,
Daeseok Youn
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/