linux-kernel - Re: [PATCHv4 2/7] ARM: EXYNOS: Support secondary CPU boot of Exynos4212

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 26 Apr 2014 02:42:13 +0200
From:	Tomasz Figa <tomasz.figa@...il.com>
To:	Chanwoo Choi <cw00.choi@...sung.com>, kgene.kim@...sung.com,
	t.figa@...sung.com
CC:	linux-kernel@...r.kernel.org, linux@....linux.org.uk,
	ben-linux@...ff.org, arnd@...db.de, olof@...om.net,
	marc.zyngier@....com, thomas.abraham@...aro.org,
	kyungmin.park@...sung.com, inki.dae@...sung.com,
	sw0312.kim@...sung.com, hyunhee.kim@...sung.com,
	yj44.cho@...sung.com, chanho61.park@...sung.com,
	sajjan.linux@...il.com, tushar.behera@...aro.org,
	sachin.kamat@...aro.org, linux-samsung-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org
Subject: Re: [PATCHv4 2/7] ARM: EXYNOS: Support secondary CPU boot of Exynos4212

Hi,

On 25.04.2014 03:16, Chanwoo Choi wrote:
> From: Kyungmin Park <kyungmin.park@...sung.com>
>
> This patch fix the offset of CPU boot address and change parameter of smc call
> of SMC_CMD_CPU1BOOT command for Exynos4212.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> ---
>   arch/arm/mach-exynos/firmware.c | 15 ++++++++++++++-
>   1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
> index 932129e..aa01c42 100644
> --- a/arch/arm/mach-exynos/firmware.c
> +++ b/arch/arm/mach-exynos/firmware.c
> @@ -18,6 +18,8 @@
>
>   #include <mach/map.h>
>
> +#include <plat/cpu.h>
> +
>   #include "smc.h"
>
>   static int exynos_do_idle(void)
> @@ -28,13 +30,24 @@ static int exynos_do_idle(void)
>
>   static int exynos_cpu_boot(int cpu)
>   {
> +	/*
> +	 * The second parameter of SMC_CMD_CPU1BOOT command means CPU id.
> +	 * But, Exynos4212 has only one secondary CPU so second parameter
> +	 * isn't used for informing secure firmware about CPU id.
> +	 */
> +	if (soc_is_exynos4212())
> +		cpu = 0;
> +
>   	exynos_smc(SMC_CMD_CPU1BOOT, cpu, 0, 0);
>   	return 0;
>   }
>
>   static int exynos_set_cpu_boot_addr(int cpu, unsigned long boot_addr)
>   {
> -	void __iomem *boot_reg = S5P_VA_SYSRAM_NS + 0x1c + 4*cpu;
> +	void __iomem *boot_reg = S5P_VA_SYSRAM_NS + 0x1c;
> +
> +	if (!soc_is_exynos4212())
> +		boot_reg += 4*cpu;
>
>   	__raw_writel(boot_addr, boot_reg);
>   	return 0;
>

This patch should be applied independently of Exynos3250 support. 
Kukjin, what do you think?

Anyway,

Reviewed-by: Tomasz Figa <t.figa@...sung.com>

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/