linux-kernel - Re: [PATCH 3/5] staging/lustre/lnet: fix potential null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140427224019.GD1563@kroah.com>
Date:	Sun, 27 Apr 2014 15:40:19 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Oleg Drokin <green@...uxhacker.ru>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Oleg Drokin <oleg.drokin@...el.com>,
	Dmitry Eremin <dmitry.eremin@...el.com>
Subject: Re: [PATCH 3/5] staging/lustre/lnet: fix potential null pointer
 dereference

On Sun, Apr 27, 2014 at 05:17:24PM -0400, Oleg Drokin wrote:
> From: Dmitry Eremin <dmitry.eremin@...el.com>
> 
> Pointer 'tsc' returned from call to function 'sfw_find_test_case'
> at line 571 may be NULL and will be dereferenced at line 572.
> found by Klocwork Insight tool
> 
> Signed-off-by: Dmitry Eremin <dmitry.eremin@...el.com>
> Reviewed-on: http://review.whamcloud.com/9386
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629
> Reviewed-by: John L. Hammond <john.hammond@...el.com>
> Reviewed-by: Isaac Huang <he.huang@...el.com>
> Signed-off-by: Oleg Drokin <oleg.drokin@...el.com>
> ---
>  drivers/staging/lustre/lnet/selftest/framework.c | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lnet/selftest/framework.c b/drivers/staging/lustre/lnet/selftest/framework.c
> index 050723a..c141f93 100644
> --- a/drivers/staging/lustre/lnet/selftest/framework.c
> +++ b/drivers/staging/lustre/lnet/selftest/framework.c
> @@ -547,10 +547,16 @@ sfw_test_rpc_fini (srpc_client_rpc_t *rpc)
>  static inline int
>  sfw_test_buffers(sfw_test_instance_t *tsi)
>  {
> -	struct sfw_test_case	*tsc = sfw_find_test_case(tsi->tsi_service);
> -	struct srpc_service	*svc = tsc->tsc_srv_service;
> +	struct sfw_test_case	*tsc;
> +	struct srpc_service	*svc;
>  	int			nbuf;
>  
> +	LASSERT(tsi != NULL);

Asserts suck rocks, which is why we avoid them at all costs.  Please
just fix the code to work properly.  If that parameter can be NULL, then
properly handle the error and return, don't oops the kernel.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/