linux-kernel - Re: [PATCH] staging: line6: fix possible overrun

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140427224425.GQ26890@mwanda>
Date:	Mon, 28 Apr 2014 01:44:25 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Mateusz Guzik <mguzik@...hat.com>
Cc:	tiwai@...e.de, gregkh@...uxfoundation.org,
	devel@...verdev.osuosl.org,
	Laurent Navet <laurent.navet@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: line6: fix possible overrun

On Sun, Apr 27, 2014 at 10:00:43PM +0200, Mateusz Guzik wrote:
> > >  and a WARN_ON + -EINVAL in line6_init_audio to catch future
> > >  offenders.
> > 
> > Returning -EINVAL is a bad idea because it would break the driver
> > completely and make it unusable.
> > 
> 
> Well I would vote for returning the error anyway.

I'm trying to be polite, but you are talking about adding regressions
deliberately...

It's very rare for people to deliberately add regressions to the kernel.
I have only seen it one time before.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/